Versions Compared

Old Version 9

changes.mady.by.user Gilles Thouenon

Saved on

compared with

New Version 10

changes.mady.by.user Gilles Thouenon

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

available at TransportPCE meetings
https://wiki.opendaylight.org/display/ODL/TransportPCE+meetings


02/09/2023

General information

Review

  • Status on transportpce changes merged  since last meeting:

    • "Autonomous, impairment aware path computation” was merged at the end of last week.
    • "Fix Pylint issues": solves a small issue in one functional test
    • "Use a coherent style in common InstanceIdentifiers” is the first of upcoming changes.
  • transportpce changes under review:
    • "Refactor graph PostAlgoValidator step 1…3" : provides some refactoring of the PostAlgoValidator method. Step1 focuses on code style and intermediate variables. Step2 is a real refactoring of the method to reduce its complexity. The problem is that comments might be adjusted as some part of the code has been moved to separate method. Step3 focused on checkOSNR to decrease its complexity. Olivier will have a look to them
    • “Refactor networkmodel serv. FrequenciesServiceImpl”, “Refactor PCE networkAnalyser PceLink” focus on code style issues, intermediate variables….
    • "Hack to update degree port on portMapping” has been tested by Tianliang on real devices and seems to work in 4 different scenarii. This change allows the OFC demo running. It can be merged now.
    • "PortMapping to support regen capabilities” has been adjusted by Bala. A few test files still need to be adapted, and Bala will push them in a short time.
    • “Support create/delete interfaces for regen” is almost ready to be merged as soon as it will have been rebased. Bala tries to write associated functional test. For this, he needs to adjust the configuration files (transportpce-oper-XPDRA2.xml). However there is an issue : one function does not succeed to find a circuit-pack, whereas this last appears in the operational DataStore when the device is mounted. From some discussions appeared that the Configuration DataStore is however not well populated. Honeynode starts successfully, but an error is generated about the schema. The issue may be related with the XSLT transform that may need to be upgraded with a new parameter, used in regen which is “recolor”.
    • “Remove use of ODL blueprint extensions” has just been submitted by Robert

02/02/2023

General information

  • ODL distribution released in Cl-SR2
  • Annual LFN Operational survey has been launched. Gilles proposes that some of us reply to this survey to provide feedback which would help notably, improving processes (https://linuxfoundation.surveymonkey.com/r/RN6HQYK)

Review

  • Status on transportpce changes merged  since last meeting:

    • “Workaround to install tapi feature in func tests”: allows starting karaf with the appropriate configuration file where tapi feature is already installed.
    • “Unenforce Lighty use in CI”: switch from lighty.io runtime to the karaf one
    • “Remote websocket config from post-install scripts”
    • “Add tests utils ODL startup  opt-out support” allows disabling the start of the controller when launching test, and associates karaf start mode to a variable.
    • “Use karaf client batch mode” : Karaf 'client' command has a batch mode option ('-b') to take commands from stdin without requiring TTY. Hence this option makes it possible to run the command without getting affected by the Karaf terminal property setup issue. Gilles is not sure this change may not lead to some issues with Linux terminal, but the change has been merged. Additionally previous change may not be needed anymore, as this one is merged.
    • “Restore TAPI feat install w/ Karaf client in tests” will need to be updated
    • "Add test_utils ODL startup opt-out support"
  • transportpce changes under review:
    • “Slight refactor of common PortMappingVersion2.2.1” is about optimization trying to avoid the use intermediate variables.
    • “Improve functional test launcher pytest support” addresses the difficulty to stop some processes with ^C. Guillaume would like Gilles to test it.
    • “Autonomous Impairment aware path computation” : Olivier addressed most of the Guillaume comments. Still a few comments need to be addressed, and some conflicts to be solved, but this change is close to be merged.
    • “PortMapping to support regen capabilities”: It took some time to Bala to make some corrections since the creation of interfaces was not working with some of the real equipment in the labs.
    • Migration to Argon: nothing new since last week

...

  • An equipment manufacturer works on R10.1 of device models. Bala did not identified major changes from 7.1 to 10.1. But the support is required in PortMapping. Rendering part should not be that much affected. The migration to 10.1 shall be needed to test the product as it will be released in the Open Lab. Currently UTD has one of their equipment which is a Switchponder with 100G line port. But the new unit shall be a 400G transponder. Having an example of configuration file for TPCE sims would help a lot.

01/26/2023

General information

Review

  • Status on transportpce-models changes merged  since last meeting:

    • Migration towards Argon
    • ”Update upstream dependencies” (mdsal & Netconf) to use the latest ones
    • Gilles also tried to merge the T-API 2.4.0 but reverted it. He wants to finish the migration to Argon prior to manage the integration of T-API models to avoid conflict/issues.

  • Status on transportpce changes merged  since last meeting:

    • changes related to backports to stable/chlorine to release Cl-SR2
  • transportpce changes under review:
    • “Slight refactor of common PortMappingVersion2.2.1” is about optimization trying to avoid the use intermediate variables.
    • “Hack to update degree port on PortMapping” will not be merged soon as we need some feedback from Tianliang
    • “Improve functional tests launcher pytest support”  propose to use pytest from the python interpreter to avoid generating unwanted behavior and so that all associated subprocesses are killed using Ctrl C.
    • New relation chain concerning the CI :
      • “Workaround to install tapi feature in funct tests” will solve the installation of the T-API feature in Karaf while the identified bug with Karaf is not solved
      • “Unenforce Lighty use in CI”
      • “Remove websocket config from post install script” solves some issues with the obsolescence of some dependencies
    • Migration to Argon: Gilles wanted to make it quickly in order to provide feedback towards kernel projects if some issues were encountered. Appart karaf issue
      Jira
      showSummaryfalse
      serverOpenDaylight Jira
      serverId355b3776-d12d-3197-b123-4e6c3281c19a
      keyTRNSPRTPCE-701
      , everything seems OK
      • “Bump upstream dependencies to Argon”: migration of the master branch to Argon
      • “Clean Maven file” solves some compilation warnings

...

  • Bala is using Inteligy IDE, but can’t see the import of the OpenROADM yang files. This is associated with the move of those to transportpce-models dedicated repository. They should appear in external-dependencies when selecting project files view in this IDE.

01/19/2023

General information

  • Gilles released last week transportpce-models artifacts for Cl-SR2, and is planning to release transportpce Cl-SR2 artifacts tomorrow

  • Casey sent a mail regarding mentorship (accompanying students or other people to work in a LFN opensource project)

Review

  • Status on transportpce-models changes merged  since last meeting:

    • “Bump upstream dependencies to Cl SR2”, to release artifacts

  • Status on transportpce changes merged  since last meeting:

    • “Refactor few LOG messages management” which extracts some modification that can be applied out of the autonomous path computation
    • “Bump upstream dependencies to Cl SR2" to use the latest dependencies (especially transportpce-model release version and the latest lighty version)
    • Relation chain concerning Junit tests refactoring
    • backports on stable/chlorine branch
  • transportpce-models changes under review:
    • “Add new T-API-2.4.0 models”: Gilles added new tapi models after correcting some trailing spaces. Anyway, Pyang still generates a lot of Warning associated with imports. This could be an issue with Pyang. The models however compile correctly on the gate. Would be worth adding a yang linter on the CI
    • “Bump upstream dependencies to Argon" has been updated to align with latest dependencies and can be merged
  • transportpce changes under review:
    • “Slight refactor of CommonPortMappingVersion221” provides some optimization removing some intermediate variables
    • “Hack to update degree port on portMapping”: Guillaume steps back on one of the optimization of previous change
    • “Autonomous impairment aware path computation” needs to be rebased again, and wait for a last review before being merged

...

View file
nameOM-Catalog-use.pptx
height150

01/12/2023

General information

  • netconf-5.0.0 being just released, we can start now our migration to Argon

Review

  • Status on transportpce changes merged  since last meeting:

    • “Use Maven 3.8.7 in CI CentOS install script”, was pushed to repair our CI
  • transportpce changes under review:
    • “Autonomous Impairment aware path computation” : Olivier has addressed most of Guillaume's comments. Remains some questions regarding the log level to see with Guillaume.
    • Jonas proposed a change to make the OLM process stopped when one node is no longer connected to the controller. The change makes the JUnit tests associated with OLM failing. In this context, Gilles proposed  a relation chain to address this and to improve Junit test relevance and efficiency.
      • “Check input node parameters of get PM RPC”: It notably solves a NPE when we invoke a node which is not connected
      • “Rewrite Junit tests of PowerMgmt implementation” : Gilles rewrote the Junit tests trying to avoid multiple write operations in Data Store to improve the test efficiency, and using Mockito
      • “Rewrite Junit tests of OlmPowerServiceImpl” : Gilles also rewrote the Junit tests for the same reason, and in the same way

      • "Remove getNode method from OlmUtils": uses get node method of PortMapping rather than creating a redundant one in OLM Utils.

    • “Support create/delete interfaces for regen”: Bala addressed some comments from Guillaume but he still has some work to do on it.
    • “Bump Upstream dependencies to Cl SR2 “ can be merged.
    • “Complement sims configuration files” can also be merged

01/05/2023

General information

  • ODL Cl-SR1 distribution was released released en 2022 with transportpce-models and transportpce projects integrated as managed projects.
  • Next step are Cl SR2 which is planned for the 23rd of January and Argon due for the 16th of March.

Review

  • Status on transportpce-models changes merged since last meeting: all changes are associated with the integration in Cl-SR1, and bump of upstream dependencies to Cl-SR2

  • Status on transportpce changes merged  since last meeting:

    • same kind of changes related to the integration of the project inside the distribution
    • backports of changes from stable/chorine branch towards master
    • backports of few changes from master to stable/chlorine, forgotten for Cl-SR1 that will be present in Cl-SR2
    • Change from Jonas on LLDP control

...