You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 12 Next »

Meetings connection details

available at TransportPCE meetings
https://wiki.opendaylight.org/display/ODL/TransportPCE+meetings

03/10/2022

General information

  • Sulfur release

    •  code freeze on managed project next Monday. All our upstream dependencies should be available to start our master branch migration to Sulfur. We will then have 1 month to release transportPCE.

    • Sulfur will include OpenROADM service and network model migration to release 10.1.

    • Let's note already that from the moment we have migrated, Maven 3.8.3 will be necessary to build the project.

Code Review

  • Since the last meeting, 9 changes have been merged.

    • “Bump Kafka clien to 3.0 ?.0” and “Fix a bug in a Junit nbiNotifications test” are related to a better version of our kafka-client dependency in nbinotifications module which not provide an incompatible version of Jackson transitive dependency.

    • Also the 2 last tstep of PCE OTN Node refactoring

    • the group of 5 changes pushed by Gilles that are related to the preparation of the Sulfur migration. (“Remove usage of schemaPath from converters”, “Clean dependency declaration in common module”, “Remove usage of deprecated InitMock methods”, “Remove usage of DOMnotification Router. Create method”, “Cleanup Junit test”). They replace object marked as deprecated for removal.

  • Discussion about other changes under review:

    • “Adding Kafka messages for OFC22” => change pushed by UTD. This is the code they are using to make the OFC'22 demonstration, as they were missing some notification messages and also some elements related to alarms. Gilles proposed to put this change in progress and private to limit the visibility since device configuration are embedded. As it stands, this change could not be merge.
    • 3 changes related to netmod notifications
      • “Update karaf cache nc-notification Yang schema” was initially inside a change proposed by Shweta a moment ago and reintroduced here by Guillaume.
      • “Fix notification subscription issue” was already discussed.
      • “Reintroduce netmod dependency” is proposed Guillaume to solve some issues introduced by preceding change. Changes are now in the right order, and they can be merged

    • 2 changes related to the power value precision inside OLM module

      • “Fix power value precision bug” is a proposal from Bala. Guillaume splited the change to separate the rounding associated with power value and the one associated with MC width which is now handled in the following change. This change is merged in session.

      • “Fix the mc-precision for OLM Power value”. We should wait before merging this change.

    • 5 changes related to the service models migration to 10.1

      • “Refactor transportpce-routing constraint model” => preliminary step to finally remove the transportpce-routing-constraint that was redundant with the official openroadm model for routing constraint.

      • "Remove transportpce-routing-constraint model" => allows an interesting code dusting, removing now unnecessary classes that was dedicated to convert offical openroadm-routing-constraints to transportpce-routing-constraints.


      • “Upgrade openRoadm service model to 10.1” => has been also rebased.


      • On top of this Guillaume pushed a change “refactor b/c of services models 10.1 update” which focuses on a proposal of a new code style for TransportPCE. Gilles think the principle of having a clear code style inside TransportPCE is a very good thing, but on the other hand, does not totally agree with Guillaume's proposal, especially the fact that systematically put everything on a new line. Gilles suggests every coder could have a look at this code so that they could have an idea of what is suggested by Guillaume, and we can decide later which coding style rules we could agree on and generalize on the project. In the rebase, Gilles modified tow classes (PceTestData and PathComputationServiceImpl) with Gilles's suggestion for the new code style. The advantage of Gilles proposal, is that we save indentation spaces when we have long namespaces, and above all, we can automate much more adjustements directly with eclipse IDE.

      • In ”Rewrite the whole DowngradeConstraints test class”, Gilles also took advantage of the rebase to also appy his code style proposal. Result is esay to see.

    • 1 change related to PCE bug:

      • ”Manage 100GE on XPDR with a list of xponder” has been pushed by Christophe to handle 100GE use case when port or device-name are precised in the service-create request.


    • Always the 4 changes from Nokia on T-API connectivity service and notifications. Gilles proposes that we integrate these T-API changes in the Sulfur distribution.


    • Javier is working on integrating OpenConfig models and translating them to T-API. Honeynode using Generic OpenConfig configurations could be used. Currently, Nokia equipment implement specific Nokia models. To see how the code/node configuration may be adapted without nokia specific models.

A.O.B.

  • Gilles would like to discuss about the status change of transportPCE. Currently TransportPCE is a self-managed project. Guillaume, as the TSC chair reported that it could be the right time to move from this mode to an MSI mode (Managed Snapshot Integrated project). Some tasks would be done by other committers of the ODL community (typically, when major API change on core MRI projects), and our release process could be simplified (as being integrated in ODL processes). The drawback for us could be the fact that we would have to follow more stricly the release schedule, especially regarding the code freeze deadline. So this project decision needs to be discussed more deeply during our next meetings before we make the decision. At first sight, that could be applied for Chlorine release train.

03/03/2022

Code Review

  • Since the last meeting, 6 changes have been merged.

    • ”New API for GNPy” has been released in time for OFC demo.

    • ”Refactor common JsonStringConverterTest”=> new change proposed by Guillaume that improves code style and intermediate variable removal, mainly related with test of the Json Serializer.

    • "Refactor PCE network analyzer PceOtnNode step 6 + step 7"

    • 2 changes from Gilles:
      • ”Clean up pom files of Maven project”=>every pom files have been revised to update dependencies, and remove unused ones

      • ”Remove overriding version for lighty pom”=> fix a dependency version overriding

  • Discussion about other changes under review:

    • The change provided by UTD has been solved by Gilles and is now ready for the OFC'22 demo. This change does not aim at being directly integrateda and merged because it does not follow the approach we use in nbi-notification. However, it is very interesting and provides the right level of information  for service creation. So, it will serves as example to provides relevant guideline to do corresponding modifications in nbi-notification after we make some refactoring of this module.

    • Another change “Bump Karaf client to 3.0.0“has been provided by Gilles to update the Kafka dependency used in nbinotifications module, following the issue solved with the UTD change. The old dependency version used in TransportPCE was providing a different version of Jackson already available with odlparent. The new version of kafka-client does not provide jackson dependency and prevent from conflits in karaf. This new version pointed out a bug that as been fixed with the change “Fix bug in a Junit nbiNotification test“.

    • ”Refactor PCE network analyzer PceOtnNodes step …” includes several changes made step by step. These changes focus on reducing cyclomatic and cognitive complexity

    • ”Fix issue in PCE with multiple xpdr” => Christophe is working now on modifying E2E functional tests which shall be ready tomorrow morning. This change addresses inputs provided in the service-create on the port and modules to be used

    • ”Power value precision bug” has been pushed by Bala. A lot of comment made by Guillaume about the rounding of intermediate computations. Bala will add some comments to explain why this is needed.

    • ”Reintroduce netmod dependency” is introduced because some devices do not advert their capabilities correctly which causes error for subscription. The previous fix removed netmod dependency. It is reintroduced handling this failure case in a better and different way.

    • A new serie of changes is proposed by Gilles to prepare the migration to Sulfur. ”Remove usage of SchemaPath from converters”, “Remove usage of deprecated initmock method”, “remove usage in DomNotificationRoute create meth” solve warnings during the compilation, and are in the scope of removing deprecated object, providing workarounds to address changes planned with yang tools.

02/24/2022

General information

  • P-SR2 has been released at the beginning of the week.

  • Gilles has updated the wiki page since some links were obsolete (meeting minutes). Release notes section seems also a bit obsolete since release notes are now integrated in the docs. We shall update the link to point to this official docs.

Code Review

  • Since the last meeting, 22 changes have been merged. All these changes have been already reviewed and discussed yesteraday during the Project Demo meeting.

    • Keep available frequency maps when Netconf sessions restores has been merged today.

    • All changes merged on master have been backported to stable/phosphorus. Unfortunatelly, there is a serious issue on that branch. Some functional tests of the renderer for device  2.2.1 systematically fails on the gate (Test 27 & 41) (Missing ODUCN interface in the portMapping). This is an error Bala tried to fix, and it was working on his side locally, but it seems it still does not work on the gate. Bala will continue to analyse the issue.

  • Discussion about other changes under review:

    • “New API for GNPY” => Ahmed still had some issue with tox and the python version, but it seems it is solved thanks to Guillaume recommendation. Ahmed solved an issue that came from the fact that for nodes that do not have IP address, such as amplifiers, were no more filtered (because we don’t use anymore IP address), and they were included is the path that returns GNPy in some specific cases. So the functional test that failed now passes.

    • “Fix issue in PCE with multiple XPDR” => Christophe continued to work on the use case to handle multiple XPDR. The creation of service is successful but he still needs to solve an issue with the deleting phase. We will need to refine the use cases we need to address. Some of the security checks performed in the Renderer probably don’t need to be performed anymore.

    • During the meeting, we have visibility on a private change puhsed one week ago by UTD: “adding UTD kafka messages for OFC22”.

      • The change proposes a simplified log reporting towards a kafka broker when we create/delete a service by TransportPCE.
      • Currently, this implementation makes failing installation of any additional transportpce features (odl-transportpce-swagger, odl-transportpce-nbinotifications, etc). Christophe and Gilles will try to look at it, to see if they can propose something that does the same but aligned with what was defined in nbiNotification; because what UTD tries to do can be done in a different way leveraging existing features. UTD sent an email which was dropped in undesirable mailbox…. because of the attachment
  • AOB:
    • ONES summit will be from 12 to 14th of April. It will be virtual

02/17/2022

Meeting canceled

02/10/2022

General information

  • Si-SR4 Release => Guillaume released last week TransportPCE for Si-SR4 and updated the release note in the afterwards.

  • P-SR2 => We are still waiting for the release of upstream managed projects (especially NETCONF). This should happen next week, and we should release our artifacts at the end of next week. Our stable/phosphorus branch is up to date, aligned with status of master branch.

Code Review

  • Since the last meeting, 10 changes have been merged. Let's mention the following:

    • 3 changes associated with the intermediate rates, including:

      • “Update power target mask for mixed line rate”,

      • “Update 7.1 port mapping after inf delete” =>allows to delete ODUCn and OTUCn interfaces in the portMapping when a service is deleted and corresponding interfaces are deleted on Devices. The functional test shall be updated to test the portMapping. Bala will add corresponding Jira ticket.

      • "Correct width for 200G and 300G".

    • 6 refactoring-related changes from Guillaume. He made some refactoring on OpenROADM OTN topology, using maps instead of lists and switch-cases in place of if/else. He initiated the same work on PceOtnNode.

    • 1 change from Robert Varga related to the way we were using the Json parser to avoid using deprecated methods.

    • 1 change from Jonas, ”PortMapping for SRGs with multiple circuit packs"

  • Discussion about other changes under review:

    • “Fix Bug in PCE picking wrong client port”:

      • initially, solved a blocking issue identified by ATT during the OFC demo preparation, regarding a bad client port selection at the PCE level. After that, Bala has also discovered other issue concerning this time the Network port selection.

      • Gilles solved the initial PCE issue, but discoverd another Bug on the T-API connectivity side.

      • Shweta also proposed to include a check on A and Z end to select only port that have the correct tails, which is consistent with the jira ticket description mentionned in this change.

      • This change solves at least the initial blocking issues, passes the gate... but Guillaume proposes to split it through different changes.

      • However Gilles think that such change solving blocking issue that also blocks some activities should be merged as soon as possible.

      • Finally, Guillaume will apply its proposed code optimization and will merge the change.

    • “Distinguish available SRGs for uni/bi-direction”: as for the previous change, Guillaume will address its proposed code optimization and will merge it.

    • “Getter for port-capabilities in PortMapping":

      • solves an issue discovered during the OFC demo preparation. There are 2 ways of advertising port capabilities and there is no restriction to use one or the other. Bala complemented the way we handle it to address both use cases.

      • Guillaume made a refactoring suggestion but Bala experiences some issues implementing the patch addressing this. He needs help to handle it. Guillaume will help him.

      • Moreover, Gilles mentions we will need to update Honeynode sim configurations and develop the corresponding functional test.

      • This modification should also be applied for device in release 1.2.1.

    • “Remove maintenance state-signal”: could be merged

    • “Bug in interface delete 400-G-Ethernet” : solves an issue introduced when we added the support of ODUFlex interfaces, which concerns the order to respect to delete interfaces and their supporting ones.

    • Jonas proposed a new change to solve the issue he reported last week about the node creation inside PortMapping and topologies after a loss of the NETCONF session (not a voluntary disconnection of the controller from the device).

      • when the device is connected again to the controller, the AvailFreqMaps should be the same as just before the disconnection.

      • This correction will be of high interest for AT&T. Bala will test it on ATT lab with its devices.

    • “Upgrade OpenROADM Network model 10.1”: big change from Christophe that does not pass the gate but should... This is probably just an issue with the gate.

    • “Upgrade OpenROADM Service model 10.1”: Gilles reworked the series, taking into acount most of comments received from Guillaume, Shweta. Gilles also pushed a new one regarding the rewrite of the unitary test about downgrading routing constraints.

    • GNPy interconnection: a new branch was created on Github. We will have the latest version of GNPy ready next week. (Docker and PyPi). Ahmed made all the modification needed in the code of tpce to communicate with the new version of GNPy. In GNPy, they have replaced the IP address that identified nodes by names which is a good thing. Ahmed is currently working in tpce on new code to provide the correct rate in the request.

02/03/2022

General information

  • Si-SR4 Release:

    • We need to release Si SR4 now. A few changes have been backported by Guillaume last week. We can let the branch as it is. Managed project seem to be ready. Guillaume volunteered to stage this release
    • Si-SR4 released during the meeting by Guillaume

  • P-SR2:

    • Our stable/phosphorus branch is no longer up to date, but Gilles is ready to backport all the changes that have been merged this week. Managed projects should be ready to release very soon.

Code Review

  • Since the last meeting, lots of changes have been merged. Let's mention the following:
    • "Fix the GNPy version used for tests to 1.2.1" => to fix the version of GNPy used for TPCE functional tests
    • Bala's series related to intermediate rates

    • "Unrecognized if-supported-capabilities" =>One of the devices was reporting some missing functionalities in the portMapping which was causing some NPE. This change is solving the issue.

    • Guillaume focused on the functional test aspects and the migration to RFC 8040 (OTN renderer, OTN SH Renderer): functions rationalization, migration. He has achieved url migration to RFC 8040. Sometimes, get a 500 message. He has raised a Jira ticket to get this fixed, even if the cause is not that well identified. In “refactor networkmodel util OpenROADMOtnTopology”, Guillaume identified some potentially missing code to handle ODUC2/3 and added some TO DO statements to be checked by reviewer to identify whether the code is really missing or not.

  • Other changes under review:

    • ”Update power target mask for mixed line-rate” => this change proposed by Bala could be merged, but we shall wait a bit to check that Jonas is fine with the answer provided.

    • “Fix bug in PCE picking wrong client port” => this change could be merged even if it does not solve completely the bug highlighted by Bala. The correction only applies to OTN mux/switch-ponders. It does not apply to transponders, for which only the first port available is selected. In this change, Gilles added some parameters passed from the SH to the PCE to handle constraints on the port to be used , but the code to handle this on transponder still needs to be written. Shweta added a comment: AT&T has already written some code to also check that the port are connected through an existing link before selecting them. Shweta will provide a patch to add this feature.

    • “Correct width from 200 and 300G” => is ready to be merged.

    • “PortMapping for SRGs with multiple circuit packs” => Jonas provided this change to fix an issue on portmapping. It could be merged.

    • Gilles pushed a series of changes related to the upgrade of the service model. There are under review for a while. They could be ready to be merged now.

  • Other maters discussed:

    • Jonas raised a bug (594) to highlight the fact that at node reconnection (after a Netconf connection failure), the frequency map is reset. In fact this issue is a more general issue associated with the way we build PortMapping that shall be reconsidered but will be a huge work (interfaces, roadm network connections, odu-connections shall probably be uploaded from equipment after a NETCONF disconnection)

    • Good practices regarding change review:

      • A change shall not be merged if some comments are still unresolved (except if they are solved in another change, (but this shall be stated)

      • Only the person that made the comment shall decide to change its status to solved unless it is obvious that comment has been fully addressed (like typo, trailing spaces….)

      • Should wait at least 24 hours before merging a change that has been submitted to let enough time to other committers to agree or not on the merge.

01/27/2022

General information

  • Next Phosphorus Release:

    • Managed projects should release P-SR2 soon. We are still waiting for Netconf artifacts availability.

  • Bala created 2 branches for OFC demo which are aligned on the master branch : OFC22 & OFC22-Demo (One of them should has been deleted, but not the LFN rights to delete it)

  • Si-SR4: Gilles has bumped upstream dependencies for Si SR4. Christophe suggests that we backport the change related to the OLM timer management by environment variables in Silicon SR4. Guillaume will take care of it.

Code Review

  • Guillaume made a few changes associated with the migration towards RFC 8040. This includes Flexgrid tests. Next step will be to look at the renderer functional tests.

    • “Migrate renderer functional test to RFC 8040” => Some refactoring is however needed

    • "Update GNPy functional tests” => change removes the dependency to the docker hosting the GNPy Server and change it to a Python Package.

    • Device change notification support was forgotten in lighty.io build.  Guillaume has created a user story related to it.

  • Gilles pushed a change to address a bug detected by Shweta and experienced again by Bala in the labs : “Fix bug in PCE picking wrong client port“. As we did not consider the port mentioned in service create rpc and client port selected by the SH is the first available port, this led to wrong behavior in some cases. So this has been corrected. However solving this through a fix highlighted another bug in T-API implementation with a wrong conversion from a client to a network port, which has also been corrected.

  • Bala pushed a number of changes associated with intermediate rates handling :

    • “Change in interface Naming convention (B100G)” : solves an issue with the OLM. Uses different interface names according to the rate for OTUCN ODUCN and OTSiG

    • “Device Renderer support for intermediate rates” : In this change a dedicated method is deducing the rate from the modulation format.

    • “Update TransportPCE topology enums” : adds OTUCN and ODUCN links in the topology after they have been created.

    • Some changes in the SH and the PCE have also been pushed to allow end to end service creation at intermediate rates : “Update SH and PCE to support intermediate rates”. This change was highly simplified by the last refactoring introducing service types. One thing still needs to be corrected : creation of OTUC4 and ODUC4 links in place of OTUC2 and ODUC2 after a 200G service creation.

    • “Update MW-MW power Mask for mixed line rate” : Update the power for 400G/100G mixed line rate to follow the new OR specification (V4.0 and higher)

    • “Correct width for 200G and 300G” change corrects the signal width associated with 200 and 300G services to 75 GHz to make it fit with the specifications.

  • Gilles is still working on the migration of models  from service 7.1 to 10.1. He is still experiencing some issues with some of the functional tests associated with GNPy.

01/20/2022

General information

  • Next Phosphorus Release:

    • Our stable/phosphorus branch is still not locked, but it should happen in a short time. We will probably have one week of delay.

  • Next Si-SR4 Release:

    • we will need to bump to upsteram dependencies, but there is not so many things to backport since this release will focus on solving security issues with Log4Shell.

Code Review

  • No change merded on master branch this week. Only few backport changes on P and Si.
  • 7 changes from Bala, under review, related to intermediate high rates handling on renderer:

    • “Add missing ODUFlex interface” => Bala noticed working on intermediate rates that this odu-flex interface was missing. This change solves this issue, and added the corresponding test on the functional test suite. Discussion to explain Guillaume's CR-1. A priori, solved by change 99399, so ready to be merged after closin Guillaume's comment

    • “Generalize supporting interface (B100G) in portMapping” => generalizes the handling of supporting OTUCN interfaces. Ready to be merged.

    • “Change in interface naming convention” => this change is necessary to differentiate 200/300 and 400G interfaces. Ready to be merged.

    • “Device Renderer support for intermediate rates” => this change complements the Renderer to handle the creation of intermediate rate services (200/300/400G). Type of interfaces are derived from the modulation format. Gilles thinks that the 3 first changes could be merged as they are. The 4th probably need to be refactored a bit considering the comments that were made.

    • “Device renderer functional tests intermediate rates” =>provides the new functional tests associated with intermediate rate interface creation by the renderer. Still some open comments.

    • “Add support for 200G with 31.6 Gbaud” => 200G QAM-16 has been added to the specifications so that we need to handle 200G with potentially 2 options. The right option is selected from the modulation format and the width (QAM16 + Spacing/spectral-width = 50GHz à 200Gbit interfaces).

    • “Device renderer support for 100G on 7.1 models” => this change currently fails, but the reason for this has been identified. AT&T has some equipment in its labs supporting this rate with 7.1 model.

  • 1 change from Guillaume on functional tests migration to RFC8040: Guillaume would like the team to review its change. Gilles has just started it before the meeting
  • 2 changes from Gilles related to Service model migration to 10.1. Gilles noticed that between OpenROADM models 10.0 and 10.1, there are some huge modifications in the way routing constraints are handled. TransportPCE internal model describing routing constraints was based on the OR Model R1.2. 
    • “Refactor transportpce-routing-constraint model” =>Gilles has started working on removing specific TransportPCE things from TransportPCE models for items that are somewhat duplicated.

    • "Remove transportpce-routing-constraint model" => remove also specific code that was writen to convert OpenROADM constraints to TransportPCE ones. This has a rather strong impact, since routing constraint are used by GNPy.

01/13/2022

General information

  • Next Phosphorus Release:

    • Our stable/phosphorus branch shall be locked next Monday (code freeze).  Release of our artifacts should be  after the 27th of January. Shall be straight forward since our branch is up to date.

    • As intermediate rate are part of P release train, everything that is related to it will be merged to the P branch, which shall be the reference branch to prepare the OFC demo.

  • Next Si Release:

    • an unscheduled Si-SR4 service release will come after the P-SR2 release to solve the Log4Shell security issue. Wait for next TSC meeting.

Code Review

  • Since the last meeting, 3 changes have been merged:

    • 99195: Removing the maint-testsignal container => already backported on stable/phosphorus branch by Bala, but not merged yet

    • 99244: Use lighty-core build rather than package dep =>it allows compilation of the latest phosphorus snapshot release of lighty.io-core

    • 99247: Update maven download URL & fix gate => allows a correct install of maven on the gate

  • The following changes are under review:
    • 99196: ODUFlex is missing => does not pass the gate (failling at building controller). It shall be rebased to include latest Guillaume change on maven install
    • 99293: Add org-openroadm-port-types yang (unoffical) to schema => proposed by Bala directly on P branch. Actually, with change "97599: Unofficial regenerator capability support in YANG", we introduced a deviation to the original model that is needed to handle regens at high rates (not every device support regeneration). Devices that support regen capability have a deviation with an added if-OTUCn-ODUCn-regen interface. To handle this issue, Bala is proposing to put in the karaf cache the model to allow mounting of both kind of devices.

  • Other activities under progress

    • Gilles has started working on the integration of R10.1 service model. He noticed some modifications on the org-openroadm-routing-constraints.yang model associated with constraints. Part of the Service Handler code will need to be modified. The migration from service models 10.0 to 10.1 could not be straigth-forward.

Q&A

  • DDF: Gilles and Christophe made a general presentation of transportPCE, and Javier presented the development made by Nokia on the T-API feature. Highstreet will also make a presentation this afternoon on their work in ONAP based on tpce for optical domain control.

01/06/2022

Code Review

  • Since the last meeting, 6 changes have been merged:
    • 96193: Power control support for 87.5GHz spectrum width => Last modification was a rebase and a Pylint issue that was solved. 
    • 98688: TapiLink creation refactoring
    • 98669: Enforce pylint in CI via tox => Guillaume enforced Pylint in CI via tox
    • 99050: Fix few NPE in TAPI implementation => a small correction on tapi implementation to avoid NPE
    • 98958: Add and fix Phosphorus lighty.io support => allows to prepare things for future lighty.io support. However the bug providing logs in Hexadecimal is still present. This means things have been adjusted on tpce side, but we still needs some things to be solved on lighty side (NETCONF dependency)
    • 98991: Use environment variables for OLM timers => allows to set the timers for the OLM through specific environment variables so that the timers can be set according to the context (simulators/real equipment). By default, the highest value of the timer is set. When using Honeynode, the correct values then need to be exported, without having to re-compile the project.
  • The following changes are still under review:

    • 99195: Removing the maint-testsignal container => the container is only needed if we set the equipment to the maintenance state. So as we don’t need it now, the proposed solution was just to remove it.

    • 99196: ODUFlex is missing => does not pass the gate (there is a compilation issue because the indentation is not good). This changes allows for service  relying on Flexo Interfaces to create the ODUFlex interface that was missing (400G).

    • TAPI changes concerning notifications => we will study the interest of merging them after the functional test have been provided

Q&A

  • Next DDF is next week with several contributions: Orange will present TransportPCE features with a life demo (Tuesday 11). Guillaume will lead a discussion about release process and tox job parallelization. Nokia will present the TAPI features of tpce.

  • No labels