Meetings connection details

available at TransportPCE meetings
https://wiki.lfnetworking.org/display/ODL/TransportPCE+meetings

06/18/2020

General information

ONES virtual event planned next week.
Orange proposed 1 session for TPCE, 1 for BGPCEP and one about LFN infra migrations and ODL scheules synchronization.

Code review

Shweta and Susmitha started to prepare the Flex Grid migration.

Some troubles with running functional tests on MAC OS
=> ongoing fixes and update of the honeynode zip files
=> Also ongoing refactoring of Functional tests

UUID stabilization on TAPI topo merged

Many update from Orange Labs Egypt and Gi

lles on Junit tests => They started to work on the common modules

Jonas bug fix / improvements merged

Ongoing huge work on the SH-renderer API update

Some bug fixes on the OTN nodes

06/11/2020

General information

There won’t be any ONES EU event. It will be replaced by the virtual ONES NA event in September.

LFN is still in the process of releasing Na SR3. We are ready to be part of it

Code review

Dependencies have been bumped to Mg SR2 on the master branch.

Thanh made a contribution to remove a dependency that what preventing ….. some jobs/features to be updated. Sonar ?
Parallelly, there was a discussion to update the image for functionald from 8c 8G to 4c 16G. => cheaper with more RAM !

OLE made several Junit test contributions. This allowed improving significantly the coverage in tpce to 40%. They will focus on the common module in the coming weeks.

Gilles started working on Junit test for network model. Change 90244 has been merged. It does not cover OTN topology which is covered in another change 90372 for which the review is ongoing.

Jonas proposed 2 changes, one to improve the way we handle spanloss, and the other to fix an OTN PCE bug.

Emmanuelle pushed 2 changes on Lighty.io.
In the first, one missing yang model registration has been solved. The pom  has also been updated. Now the tapi API can be used with lighty.
In Lighty refactoring (90379), she cleaned up some dependencies that were not used, add checkstyle from ODL parent and fix checkstyle violations.

Some functional test have been added for t-api.With lighty.io, it is loaded by default contrary to Karaf.
It appears taht some misconfigaration in bundle/feature tapi configuration prevented it from being loaded correctly by default in the ODL distribution => fixed

Gilles fixed a bug in the PCE OTN node that was introduced when solving spotbugs issues.

Run autopep8 on functional tests…..

Honeynode has been updated to support the interleave capability.

Catch portmapping failure is solving some issues with some of the new OTN switch equipment AT&T has on its platform. PortMapping was failing because there are some mandatory parameters missing in the equipment configuration.

SH-Renderer-API: Bala will start looking to Olivier’s comments beginning next week. Guillaume proposes to rebase this change on the current master.


06/04/2020

General information

Artifacts for Na SR3 have been published.

Orange has  proposed a discussion on tpce Mg Release at Next DDF Forum (virtual Event)

Code review

Ahmed completed some functional test to check the behavior of the PCE in different conditions related to the presence or absence of OMS attributes.
The test notably checks that the PCE does not propose path relying on some links that do not contains OMS attributes.

SH-Renderer API code to handle OTN : the code is almost ready. Before Bala starts working on functional tests, Olivier will make a functional review of the code.

Fix tapi execution : Emmanuelle fixed a null pointer exception and adapted the Junit tests.

Emmanuelle has refactored some functional tests. Guillaume would like AT&T to check and give the confirmation that the behavior is still correct in a MacOS environment

NETCONF-666 bug has been corrected and merged on Mg. It may solve the issue we observed with NETCONF notifications generated by devices in case of multiple Netconf sessions.

05/28/2020

General information

We are officially part of Mg SR1. It will be announce today or tomorrow.
Deadline for managed project for Na SR3 is tomorrow. We are ready for integration in this release, but Netconf artifact is still missing, so that we cannot stage the release.
Wiki URL has again changed from wiki.lfn… to wiki.opendaylight.org, which brings a lot of issues. Guillaume sent a mail to highlight this.
Ongoing discussion on the virtual ONS summit.

The stable Mg branch is locked. So there will not be any additional change backported to it.

Code review


OLE made some contributions on the PCE to adapt the code in the following of the Junit test they made.
Emmanuelle as developed a GNPY stub to help OLE in developing/running the Junit tests for the PCE.
Bala made a change (WIP) on the service Handler. He added otn-service-path method in SH model-mapping and updated renderer to differentiate WDM and OTN service.
The service-path was also updated with connection type.

Guillaume made some changes related with Spotbug issues on inventory and service handler. Now, except for SH, Spotbug is enforced on every module

Honeynode code is now on Github, and Jar files are downloaded directly. Original code is also available  from https://gitlab.com/Orange-OpenSource/lfn/odl/honeynode-simulator.git
This includes last changes made to make it usable in a MacOS environment.

Jamo Luhrsen mentioned that the bug encountered by Javier with Netconf might be similar to NETCONF-666 issue.  

Next Sprint

Sprint planning is on next Tuesday. Please make sure all user stories of interest for you in the backlog!

05/14/2020

General information

ODL TSC is working for Mg SR1 releasing, but the branch is clearly not ready to stage the release.
The old Wiki has been migrated to the new Confluence Wiki. All the information is there. Module description and Requirements are at the same level. It will be updated later on.

Code review

The stable Mg branch is locked. So there will not be any additional change backported to it.

Enforce spotbugs in test-common-module has been merged. Guillaume is waiting for some review on some others equivalent change prior to merge them.
The 2 contributions from Jonas on LLDP neighbours and PCE node validations have been merged
OLE has difficulties to understand PCE operation for OTN since no documentation is available.
Christophe sent a mail about the issue we observed with having several applications subscribing to notifications on Netconf device (as an example Honeynode).
Shweta mentioned is that it may be related with support of the interleave capability of Netconf in NETCONF.

Honeynode code has been pushed to https://gitlab.com/Orange-OpenSource/lfn/odl/honeynode-simulator/

Zip files corresponding to Honeynode executable are now available for 1.1.2 and 2.2.1

Next Sprint

Orange will close the sprint on Jira. After everybody has made some refinement on its user stories (acceptance criteria, detailed description….) we will start building the backlog of the next sprint so that we can set a new Sprint-planning meeting. Proposed date for next sprint planning is the 2nd of June. The period for next sprint will be from the 1st of June to the 25th of June.

05/07/2020

General information

No news about the release to come. It seems that the community is pretty late.

Code review

Additional Junit test have been pushed by OLE,  and merged.
SAPI/DAPI patch has been merged.
Bala raise the fact Building Service Handler, SLF 4J SpotBugs are coming up making more difficult the analysis and the set up.

SpotBugs is highlighting some issues, some of them being real, but others being false positive.
Spotbug is analyzing the BiCode. As an example, sometime it says that a method is not used whereas it is used because it can’t know it. SupressWB warning can be used in the code to avoid Spotbugs raising some issues that shouldn’t.  
Guillaume started working on some spotbug issues.

SH-Renderer API code to handle OTN : Bala Added otn-service-path method in SH model-mapping, updated PCE-listener to differentiate WDM and OTN service, and modified ModelMappingUtils to have input for OTN service path.

Device model 7.0 has been tagged as work in progress and will be kept in the next sprint.

Shweta proposed to give help on reviewing the 2 changes pushed by Jonas.
First contribution is about lldp neighbours discovery, changing some loops behavior.
In the 2nd, PCE optical node validation,  Jonas corrects the PCE behavior so that if PP ports on an end SRG are already used path, computation fails.

04/29/2020

General information

The presentation made in the TWS meeting was appreciated and a question/answer session will be organized next Monday.
Next LFN events : No news from next Developper forum, the ONS America has been postponed to September but it is not canceled
Mg SR1 : we can’t stage the project right now, because managed project are not ready. It shall be possible next Monday. Hopefully, we shall have one week then to stage transportPCE
A new version of checkstyle does not allow separation in the import. Stable Magnesium and Master are now pointing to Mg SR1.

Coding activity

Many changes have been cherry-picked so that we are ready for staging.
The changes on the OTN-Renderer /PCE alignment and topology update have been merged as well as a number of Junit test added by OLE for the PCE.
Fixing PCE spotbug issues : removed some uncalled method from the PCE and add some decorators to solve 2 false-positives.

Guillaume managed to fix the build error on lighty.io and updated the dependencies version to 12.1.0. It is now building and was merged. This change has been backported to the stable Mg branch.

Update device model to 7.0 : functional tests concerning the OLM are failing. The reason could be that some classes associated with the OLM are importing some yang files from common models without stating the version. By default the latest version of the common models are called. As there were a lot of changes in the common models it might be that code is not compatible with some of the elements changed in latest version of common yang models. Some R7.0 equipment may come in the lab in a short time.

SAPI/DAPI : Bala made a change based on both Hashing function proposed by Guillaume and on the contribution from Shweta. It is successfully building but currently failing (PortMapping functional tests), but Bala need additional time to identify where the failure comes from. PortMapping has been modified to include the Hashmap corresponding to the code for SAPI and DAPI.
Guillaume isolated the change related to the portmapping and put it into a separate change (ease the debugging, making easier to identify the impact on the changes of models).

Upgrade to Service Model 6.1 : propose to put it on hold and wait until the issue 678 of OpenROADM is solved (bug related on the introduction of mandatory leaves making the subrate-eth-sla container mandatory whereas it is associated to a when statement, which leads to incorrect behavior in ODL). Then rather than integrating R6.1.1 which shall solve the issue, we could directly jump to R7.1 which will also solve this but add nice features to handle MDONS use case (such as the possibility to handle several notifications urls to different ONAP subcomponents.

04/16/2020

General information

The mailing-lists have been migrated, this includes transportPCE dev list.
The presentation about transport PCE for the Tech work stream (public session) will be on the 27th.
It has been asked by the TSC, and shall be technical. A good starting point could be to reuse the presentation made top OpenROADM user Group.
The gate was broken two days ago, this means the project shall be rebuilt if no Maven cache repo is used.

Coding activity

OLE has added some Junit Tests for the PCE, increasing the overall coverage.
They also provide  the Orange Gitlab LFN-dedicated space with the documentation for the GUI.
Gilles has pushed the “bump project version to magnesium SR1” on the stable magnesium branch.
Mg SR1 is planned for the 4th of May (Managed project). We will have then one week to perform the staging.
The change on SAPI/DAPI shall be adapted (creation of SAPI/DAPI based on a HashMap of 16 Bytes, with preferably the ability to retrieve the original string from the hashmap).
The Change has been rebased (new dependencies) and put as work in progress.
OpenROADM service model 6.1 has been also rebased on new dependencies. The problem is that it modifies the service handler and does not allow to pass the end to end tests.
AT&T will analyze the log and reason for the failure of the functional tests.

Gilles pushed 2 changes to handle topology after an OTN service has been created and to align the Renderer operation with the PCE. This allows notably to update the topology with OTU4, ODTU4 (Structured ODU4) links, used and available bandwidth.  ODU0, ODU2e and  ODU4 services can be provisioned through otn-service-path and supporting OTU4/Och through service-path rpc.

04/9/2020

General Information

TSC would like to have a transportPCE presentation during a TWS meeting. AT&T is ready to support this.
Proposal to make it next Monday, but this can probably be planned at a later date which better fit with our constraints.
Martin raised the question on whether we shall try to push transportPCE for being a Managed Project.
The lack of effective committers would make it difficult at this date.
Martin suggested to discuss with the TSC this at the end of the presentation (mentioning current elements that may need to be solved).


The LFN has decided to migrate the mailing list. We shall receive of invitation to subscribe to the new mailing list.
For Aluminium we have to think about the  old Controller API removal.
This may have an impact, on the code, but  most the work was already done on the databroker migration from September for Sodium.
The Wiki shall be migrated before beginning of May.

Code review

“Update config files and tests” has been merged. It improves the testing environment for GNPY, modifying the config files.
“Improve HoneyNode Docker script” has been merged. The script to initiate the simulators has been changed.
“update lighty.io build script for Mg SR0 support”: Balla made some modifications updating dependencies and was able to build the lighty locally.

Narayan has started working on the support of 2.2.1 Devices in the inventory. He has an issue with the database management.
“Upgrade OpenROADM service model to 6.1” : Susmitha has removed old 5.1 service Model.
She suggests to keep old models in common, because a lot of modules are still using them.

03/26/2020

General information

A release note and a marketing announcement have been prepared. All self-managed projects (including transportPCE) will be in the official distribution.
GUI source code has been published on Orange public Gitlab, the docs have not been published but exist in Microsoft Word docx format, they must be converted in MarkDown.

Code review

“HoneyNode and tox scripts BSD compatible” has been merged : the idea was to rewrite tox scripts and the launcher so that they are BSD compatible and can be used on Mac.

“Calculate Spanloss crashes when OTS is not present” : Susmitha add a check on whether the OTS interface is present or not.

“Setting transponder power level when SRG Rx power range does not exist”   Susmitha made a change to set transponder power level when SRG Rx power range does not exist.

Javier working with Nokia has pushed a change  initiating Device Notification Listener functionality.
They propose to provide contribution that focus on listening to device notifications in order to trigger some network topology updates associated with the state of nodes and tps.

Docker refactoring : HoneyNode Docker refactoring is ongoing.

“Bump project to 2.0.0 and fix feature deployment change” allows bumping Master branch on Aluminum.

Several change have been made to reduce the technical debt and fix different spotbug issues (Separate changes for PCE, Common & Network and Renderer modules).
This changes also allows solving some of the SONAR issues.

03/19/2020

General information

There will be a vote today for Magnesium Release, but they are still experiencing issues with some of the projects.
Guillaume did not manage to stage the release because some dependencies are still missing.

Code review

Docker refactoring for Java 11 : Honeynode has been upgraded to Java11. The Docker that launch the simulators needed also to be upgraded.
In the docker file some changes have been made to introduce a hierarchy. Previously as all simulators and configurations were built directly on the image, the dockers used a lot of memory.
Using the Multi-stage feature of Docker, the size of the image went down from 800 to 240 Mbytes.  Also only one image is now used for all configurations. A script starts several container with their own configuration file. An option has been added to check the health of the simulators by using the REST API.

Adding SAPI/DAPI to Renderer function has been completed also removing some warnings that were generated previously and hardcoded lines.

“Update configuration files and tests” change is focusing on correcting the clfi and addresses of the nodes, and managing OMS attributes and other deprecated attributes  that were moved to the common model.

03/12/2020

General information

Magnesium release is postponed. A bug in karaf prevent some of the modules to start correctly.
Trying to stage the release, it seems that some NETCONF dependencies are not available so that we can’t stage it.

Code review

Ongoing changes on the master branch:

A change has been provided by Anil related to the documentations (migration to Python 3).
Some Changes can be pushed on Master branch. If a change is OK we can then cherry pick it and propose it for Magnesium.

Gilles is working on some adds to the topology management and the renderer to handle OTN link creation in the topology. This code has not been pushed on the repository.

Bala has been working on checkstyle issues for SAPI/DAPI code and will push it this afternoon.

TPCE GUI:
We are working with Fossology to check the licenses associated with the GUI code. After we have checked licenses are compatible, the GUI code will be pushed on Gitlab.

03/05/2020

General information

Magnesium will probably be postponed but we are ready to integrate the release.
We have received some guidelines about the migration of the Wiki (Casey Cain).

Code review

toJava functions introduced by the Magnesium migration do not support null.
The code of GNPy has been changed accordingly (addressing the case where PCE sending a request to GNPy to calculate a path, without sating the wavelength).

The transportPCE features have been reorganized . odltransportpce gathers now all features associated with tpce, ord and api models.
A feature has been added for t-api, as well as an for the inventory. The creation of a t-api bundle was not leading to creation of t-api artifact which breaks karaf.
A change has been proposed to publish the artifact locally, so that they are available to be run in Karaf

The documentations have been reviewed to include OTN support, GNPY, and T-API support (for the export of the topology).
Some example have been provided to explain how to configure OTN devices using intermediate (East/west) APIs, waiting for a full end to end support (planned in later releases of Magnesium).

02/13/2020

General information

We manage to release tpce for Na SR2.

Magnesium code freeze should have been on Monday the 10th of February. Bus as BGPCEP project is not ready, Mg shall be stable only on next Monday.
Guillaume has bumped the dependency and also migrated tox to use controller with JDK 11 and sims with JDK 8(not merged at that time).
Currently the project is building with JDK 8 and 11 with Sodium. JDK 11 is mandatory for Mg.

Maven verified job  needs to be migrated to JDK 11 (currently building on JK8). So this should not affect the current code.
A patch has been proposed to releng/builder to migrate. It has been merged during the meeting. So the gate is now using JDK11.

Code review

When AT&T is pushing code, the building process fails. LFN doc tools needs Python 3.6 . ATT changes need to be rebased on the current master to use the new version of tox.ini
PCE consolidation  (according to Jonas comment, and OSNR calculation improvement) has been merged.
The PCE OTN initial code has been reworked through  “Adapt PCE code for OTN services” commit which has been merged.

OTN renderer code and PCE code have been put on top of Upgrade to service-path1.7
OTN renderer code was initialy rebased on service path 1.7 before it was cleaned-up leading now to a merge conflict. The way to solve this has been identified during the meeting.

Guillaume is currently trying to rebase the Magnesium dependencies on top of the master branch.
There are some changes in the yang tools : they have changed the implementation of yang list leading to the impossibility of sorting correctly these list.
This breaks the functional tests.

AT&T has started working on service and network models 6.1 integration. There are some issues , probably coming from common models.
Bala has also started working on including SAPI and DAPI field on interface Builders (OTU4 creation) in the renderer but functional test fails (at the Topology level)
AT&T identified an issue with ODL parsing device responses to Netconf config edit. They need to investigate a bit further to understand whether the issue comes from ODL (NETCONF) or from the equipment.

02/06/2020

General information

The next DDF won’t be collocated with the ONS. It will be associated with the ONAP event in Seoul.

Magnesium code freeze for Managed project is beginning next week. This means that the API won’t change.


Code review

Guillaume fixed the problems with tox profiles and the gate works again.

Ahmed managed to finish his work on GNPY and addressed most of Jonas comments on the PCE. The problem of identifier for fiber and EDFA has been fixed.
The only remaining  point of discussion concerns the Belmann Ford algorithm and latency management, but Jonas agreed for the merge.


Shweta has addressed all the comments made from a functional view on the renderer which was also realigned to the service-path 1.7.
AT&T has started working on the upgrade to Service and Network models 6.1.

Christophe and Gilles pushed the new version of the PCE. They have reviewed all the code and have updated it to perform the path calculation for OTN service (OTU4 from network to network ports on OpenROADM topology, ODU4 from network to network ports on otn-topology relying on an OTU4 link, and 10GE/ODU2 & 1GE/ODU0 from client to client ports relying on an ODU4 link. They had to change the structure to introduce a new interface PceNode where generic methods are defined. These last being implemented by PceOpticalNode (previous PceNode) and PceOtnNode.

The part that misses for Magnesium are :

Emmanuelle worked on HoneyNode which can be built and run on Java11. We are currently making tests to validate the solution.

Guillaume managed to make the code build with Magnesium, but still have some issues to solve. The community has introduced spotBugs (similar to SONAR) which raises some errors.