Page History

...

available at TransportPCE meetings
https://wiki.opendaylight.org/display/ODL/TransportPCE+meetings

11/03/2022

A.O.B.

Javier provides the recordings from the TAPI v2.4 upgrade presentation

10/27/2022

General information

...

• transportpce changes under review:

  • nothing new on the 3 changes proposed by Bala on Regen functionality. Bala is currently working on a new one to add regen functional tests. All the relation chain could be merged at the same time when every changes will be ready
  • Guillaume and Nathan had a lot of exchanges this week on different topics : CI, Java version check, Kafka broker.
  • Nathan reworked his change 99746 related to send log messages outside Transportpce, in a kafka broker. Gilles raises the fact that this implementation is also outside the use of nbinotification module that had been developped for this kind of usage. Gilles would prefer we re-use as far as possible the existing base and developments provided on NBI notifications. Gilles thinks it would be preferable to use MDSAL internal notifications for communication between internal modules and towards nbiNotification module. Nathan explains that the core issue is we try to make a single Kafka producer. But there is some instability which leads to some failure of half of the tox jobs (weird failures). Nathan is about to abandon the Kafka approach. The solution he has in mind are:
    1. Solution could be to rely on nbiNotification, but this imply to make a lot of changes in a lot of classes that use notifications.
    2. Use the ODL karaf.Log and KarafAppender pluggin but it may imply to override ODL parent settings
    3. Completely abandon the Kafka approach and move to an approach based on promtail...

A.O.B.

• Bala experiences some issues testing equipment with last version of TransportPCE, with all what concerns capabilities announcement. The device if-supported-capabilities seems not being correctly recognized by MappingUtil class. Bala will investigage more deeply.

...

• transportpce changes under review:

  • “Change log level in FrequenciesServiceImpl” is correcting the Level of a LOG from Error to Warn to avoid misinterpretations.

  • “Support create/delete interfaces for regen” : source and destination tp are Network tps for on Regenerators. This is used to trigger ODUCn interfaces creation on relevant ports.

A.O.B.

• Lighty simulators can send notification, but Christophe still experiences some issues with the serialization. Thus, Tpce is not able to process this notification. DeviceChangeNotifications yang model includes an instance-id which is not correctly serialized.

• Notifications handling for SC22 demo: we need some clarification on the streams announced in the capabilities provided by the devices. Bala mentions that the equipment may only announce the support of OpenROADM streams, even if they support Netconf notifications which is a MUST. Tpce also does not process at that time  DeviceChangeNotifications on interfaces. Gilles will try to find a workaround and provide a patch that allows subscribing to the Netconf stream even if its support is not announced by the device, and that also allow handling notifications coming from state-changes on interfaces.

• Next week meeting is cancelled since both Gilles and Christophe will be at the Orange SDLRI playing the demo of optical restoration.

...

• transportpce changes under review:

  • Gilles's relation chain related to the chlorine migration step 2, with compiled models imported by maven dependencies

    • “Remove useless yang models from-test common”, is removing an old transportpce model that is not used anymore for a while

    • “Update transportpce-common-types model”  is adding pm-granularity to tpce models to solve some issues we have with this parameter when we use the one coming from OR models with models outside transportpce project (linkage issue)

    • “Fix bad imports” cleans up some imports made in tpce that were not the correct ones.

    • “Remove openroadm and tapi models building” removes the compilation of T-API and OR models, uploading a new bundle corresponding to the newly created transportpce/models project. There is still an issue with T-API functional tests because bundles do not restart automatically when we install odl-transportpce-tapi feature without restarting Karaf. Gilles is updating tapi functional tests with a workaround waiting to understand what happen in karaf.

  • Bala's releation chain to integrate the support of regen in transportpce:

    • “Port-Mapping to support regen capabilities” adds a regen profiles container which includes the supported regen profiles when the Xpdr-type is a regen.

    • “Update portMapping data for Regen xpdr-type” provides code to complement portMapping with the information required to handle Regens.

  • Christophe is still working on lighty simulators, providing some code that allows reaching the same functional level as what we currenlty have with Honeynode. He still has an issue to solve with notifications sent by the lighty simulator.

  • Olivier pushed an OpenConfig  version of the SwitchPonder configuration on the LFN/HoneyNode Gitlab that will allow to test future openconfig feature developements inside transportpce

A.O.B.

• A question was raised by Bala: shall we make 1.2.1 support deprecated? It seems that there are no more proposed/deployed products based on openroadm models 1.2.1. We will need to think about it, since this leads to additional complexity when handling objects in the service and network models that do have different format in R 1.2.1 and the next releases.

...

• Changes merged this week:
  • Re-open Drop service name from ODU Connection name
  • Gilles tested the relation chain provided by Thierry to improve the SDLR demonstration (path reroute), which works well, he also reviewed the code, and the changes have been merged.
  • Changes provided by Guillaume associated with the migration to Chlorine.

• Changes under review:

  • “Add allure Pytest tox profiles for local use” has been reviewed and reworked by Guillaume who expects Tianlang to try the modifications on his local environment to provide feedback.

A.O.B.

• Bala presented what he has done for handling regenerator in the Renderer going through a presentation.

...

• Changes merged this week:

  • Except what have been merged on Sulfur branch (Rest of the relation chain concerning migration of funcional tests to RFC 8040) most of the changes are related to the migration to Chlorine on which master branch is aligned:

    • “Adapt transportPCE code to Chlorine” is the change with the most important code adaptations to chlorine.

  • Few additional small changes proposed to improve the things:

    • "Adapt functional test to Clorine" concerns mainly OLM functional tests (migrated before chlorine)

    • “Improve feature install in functional tests”: considering latest evolutions, there is no more need to restart the controller after features have been installed.

    • Guillaume proposed some optimization through “Refactor code after Chlorine Bump” which  brings some optimization based on else if, and “Refactor Renderer OpenRoadmInterfaces step 1”. For this last change, addressing latest comments, as Ethernet CSMACD in some yang OR identities, we will need to push a correction.

• Changes under review:

  • few changes to improve code after the migration to chlorine
    • “Clean poms after Chlorine bump”: provides some updates in the dependency (some RFC reference have evolved)
    • “Fix raw types build warning”: notification need types. If they are not specified, some warning are generated, otherwise “generic needs to be specified”
    • “Fix unchecked build warnings” also allows to avoid generating unnecessary warnings
  • ==> We can now consider that step 1 of migration towards Chlorine has been accomplished

  • Relation Chain from Thierry associated with service restoration. Olivier reviewed them and is OK with the different changes. Gilles will test the code before merging these changes.

  • “Drop service name from ODU connection name” is in merge conflict. This is probably due to the migration towards Chlorine. Bala will rebase it to check.

A.O.B.

• The "developer guide" need to be updated because Json samples used for the service create are not integrating the evolutions of models to 10.1 (the documentation sill uses the 5.1 models). A JIRA user story will be created for next sprint.
• One bug reported by Jonas in last August: https://jira.opendaylight.org/browse/TRNSPRTPCE-681. Gilles replied today…

• Last part of the meeting was dedicated to Sprint29 planning:

  • Bala mentioned that we should consider, not for this sprint but the sprint after, refactoring the PCE to better consider equipment capabilities and select the most appropriate operational-modes

  • Olivier will split the story proposed by Javier “T-API Renderer” because it includes also some functionalities to retrieve a topology through a SBI

  • Gilles will add a story dedicated to the move of the models to a dedicated project.

  • Sprint starts on the 19/9 and ends on the 13/10.

...

• No change merged this last week

• Changes under review:

  • 1 change from Bala: "Re-open:Drop service-name from ODU connection name" to have the service-name in the interface name, necessary when a high order termination point supports several low order interfaces
    
  • Relation chain from Thierry on service reroute: already discussed last week. Waiting feedback from Olivier.
    

  • new relation chain of 9 changes proposed by Gilles on the Chlorine migration + migration of all remaining functional tests to RFC8040

    • "Bump upstream dependencies to chlorine": just the bump
    • "Adapt some dependencies to Chlorine": to better distinguish dependency impacts on Chlorine
    • "Adapt TransportPCE code to Chlorine": to see code modifications brought by Chlorine
    • "Migrate end2end functional tests to RFC8040": pursue the RFC8040 migration started by Guillaume for all end2end tests
    • "Refactor functional tests": rename some functions of tests-utils to be more explicit
    • "Migrate pce functional tests to RFC8040": choice to only use json file as portmapping and topology input files to perform tests, to ease the migration. To that end, Gilles has converted xml input files to json input files
    • "Migrate hybrid functional tests to RFC8040", "Migrate TAPI functional tests to RFC8040", "Migrate nbinotifications funct tests to RFC8040": continue the rest of functional tests, but Gilles didn't have time to tests these last tests, so it remains probably some bugs...
    • => so, the chlorine migratio is well advanced and at first sight, no strong issue detected...

A.O.B.

• Gilles tried to load on confluence the AVORTEx demo video, but file is too big. Need to cut it...

...

• No change merged this last week:

• Changes under review:

  • Waiting for feedback for the changes presented last week

  • WIP ODU Drop service name bug correction pushed by Bala this week

A.O.B.

• question about tox to perform a few tests selectively: answer can be found in docs at https://docs.opendaylight.org/projects/transportpce/en/latest/tox-guide.html
• Last meeting video cannot be seen outside Orange (teams configuration problem ?)
  => waiting for Gilles Thouenon return : apparently he is the only one who can retrieve the original file on its personal folder and share it outside Orange.

...

• No change merged this last week:

• Changes under review:

  • ”Primitives to retrieve parameters from Catalog”: Olivier proposed this change to provide generic methods to retrieve physical parameters associated with the performance of the devices, described in the catalog. He first focused on the primitive associated with PCE operation (that shall be called by the PostAlgoPathValidator). This change includes the primitive (CatalogUtils), Unitary tests, and the json file used to populate the Catalog

  • Refactoring of the previous change proposed by Guillaume. Double introduces precision problems in the formulation. There is also a 10 factor in the spacing correction of the formula not present in ADD case. Guillaume assumed it was forgotten but this requires confirmation from catalogs formulas further investigation.

  • Patch computation reroute request proposed by Thierry. Discussion about various aspects including "exclude parameters" with Bala and Shweta.

A.O.B.

• Bala reopened a JIRA ticket about naming convention and DUs because some unexpected side-effects were noticed.

...

• Changes merged this last week:

  • ”Migrate OTN E2E functional tests to RFC 8040 step [1 to 6]”

  • Gilles has backported the latest changes developed on master to Sulfur so that this branch is up to date for forthcoming S-SR2 integration

• 
  

  Changes under review:

  • ”Primitives to retrieve parameters from Catalog”: Olivier proposed this change to provide generic methods to retrieve physical parameters associated with the performance of the devices, described in the catalog. He first focused on the primitive associated with PCE operation (that shall be called by the PostAlgoPathValidator). This change includes the primitive (CatalogUtils), Unitary tests, and the json file used to populate the Catalog

  • ”Refactor common CatalogUtils” has been pushed by Guillaume to propose some optimizations on the code provided for the primitives.

A.O.B.

• AT&T presented the AVORTEx project dedicated to the validation of OpenROADM equipment. AT&T uses TransportPCE in the design validation phase with pre GA equipment. Automated validation is based on RobotFramework, TransportPCE and Honeynode simulators used in a first step to test testing script. AT&T is planning to opensource the code dedicated to this. Up to the transportPCE team to provide an answer on their interest to integrate these tests on their git repo.

  • View file
    name TransportPCE_meeting-20220804_part1.mp4 height 250

  • View file
    name TransportPCE_meeting-20220804_part2.mp4 height 250

  • View file
    name TransportPCE_meeting-20220804_part3.mp4 height 250

...

• 3 changes have been merged durint the week: ”FixTypo developer guide”, “Switch tests from nose to Pytest”, and “Refactor networkmodel OpenRoadmTopology part 4”

• Discussion about changes under review:

  • ”Migrate OTN E2E functional tests to RFC 8040 step [1 to 6]”: Guillaume propose these different changes to address the migration towards RFC 8040. These changes are ready to be merged. To Migrate all the tests to RFC8040, we still need to work on E2E tests (to have all 1.2.1); T-API, Hybrid test on PCE including GNPy and Notifications (to have 2.2.1); 7.1 being almost done with still a bug to solve.

  • ”Bump Lighty.io to Sulfur SR1” was merged during the meeting.

A.O.B.

• Javier tested Swagger interface, and it seems there is an issue with GNPy model. Gilles also observed this phenomena. Javier will open a ticket and provide associated additional information to help to debug this issue.

• Olivier went through his presentation Service-create-handling, and as usual, not all the slides could be covered during the meeting, meaning this will be continued in one of the next meeting…

• Let's remind that next week, a 1/2 hour time slot will be dedicated to a short demo by Bala to show ATT progress on their activity on the creating automation framework for validating OpenROADM equipment with TransportPCE.

...

• changes merged during the week:

  • ”Fix Pce calculation bug when validating nodes”, “Upgrade Honeynode sims version”, “Refactor networkmodel OpenROADM topology part 1,2,3…” and “upgrade project version to S-SR2” are part of the Sulfur-SR2.

  • Most of the T-API changes pushed by Javier have been merged. Gilles made a comment on the fact that we will need to refactor nbi-notification after these changes have been merged.

  • ”Add tests for autonomous service rerouting” provides the functional test for service rerouting and basically corresponds to the sequence of actions we plan to perform during the demo for the Orange SDLRI. Bala proposes that we organize a demo of what has been done in this scope. UTD could also be invited to this demo.

  • “Replaces tpce topology yang models by existing ord models” allows removing yang model that were in built in transportPCE and that are no more needed since equivalent models are provided now in OpenROADM.

• Discussion about changes under review:

  • "Migrate OTN E2E functional tests to RFC 8040 step1, 2,…" are completing the migration towards RFC 8040, needed for Chlorine.

  • ”Switch tests from nose to Pytest” addresses planned deprecation of nose

  • ”T-API notifications Junit test” needs to be reworked: with T-API, notification topics are created dynamically which makes it complicated to mock. We will need to find a workaround to make the tests. Javier is also waiting for feedback on “Fix getTopologyDetails in tapi func tests” to solve identified issues.

A.O.B.

• Bala proposes to make a demo on automated test validation for OpenROADM devices that AT&T is currently developing. Depending on the availability of the Orange team, this could be done either at the end of July or beginning of August.

...

• 7 changes have been merged during the week. All of them have already been discussed last week. They have not been backported to P at that time. Gilles will do that on tomorrow.
• Discussion about changes under review:

  • ”Updating the usage section of the developer guide”: new change proposed by Roshan to solve some issues with the documentation. It was reviewed by Guillaume. It seems it shall be merged after the bump in Sulfur because the old version of the apidoc is still supported.

  • ”Fix issues from PortMappingList & NetworkModelList”: new change proposed by Thierry to solve some issues related to admin/operation state changes. Status change is not correctly reflected in the topology. We also did not handle correctly administrative and operational state. Thierry’s change solves this, handling separately admin and operational states. Some Junit test have also been added

  • ”Fix some indentation issues in OpenROADM topology”. This change is the first of a chain that will be dedicated to the improvement of the code style of some of the classes with high cyclomatic complexity and a lot of indentation issues. Gilles mentions that we will need to discuss internally in the project between TransportPCE developpers the rules we want to apply to improve the code style before merging this kind of changes.

  • ”Fix the pom files to compile in Windows OS” has been pushed by Bala so that his trainees can work on Windows compatible PC. The change solves an issue with the path interpretation using Windows OS.

  • "Override asciidoctorj-diagram to 2.2.1" has been abandoned since this was an intermediate change that is not needed anymore.

A.O.B.

• Bala observed that “Adding additional Kafka messages” is leading to very long compilation time locally and to some timeout issue with Maven jobs on the gate. Thierry suggested it might be associated  with some Kafka Publisher when they are not enabled in the Junit tests

...

• Changes merged since last meeting: “Drop the service name from ODU connection name” and “Fix output response for 400GE device renderer” that were discussed last week have been merged and backported on P branch
• New changes have also been merged: “Fix code issues”, “Add new method in PortMapping”, “Clean yang modules instantiations in lighty”, “Bump Lighty  to P-SR2” and “Ugrade Honeynode version”.  They are related to the reenforcement of lighty build for Phosphorus. The code is now building but we still have some issues with some functional tests.

• Javier shall push tomorrow newer version rebased on master of his latest changes on T-API

A.O.B.

• Christophe started to work on lighty.io Netconf simulator. He succeeded in having OpenROADM 2.2.1 ROADM and Transponder nodes running. He is currently working on the management of the RPC, and he will also have to work on the synchronization of the 2 datastores after some modifications have been applied to the configuration datastore. Lighty.io does not provide any RESTONF connector. The main reason for investigating on Lighty.io is that it is a recent project which uses some of the latest ODL dependencies (Phosphorus), which makes it easier to evolve, in comparison with Honeynode which is not maintained anymore.

...

• Only one change merged since last meeting: "Update Maven CentOS install script for tests" proposed by Guillaume to take into acount the fact that the minimum version of maven is 3.8.3 in Sulfur.

• 2 Changes under review proposed by Bala:

  • ”Fix output response for 400GE device renderer”: output response provided by Renderer now indicates all interfaces that have been created, even if some of them are created simultaneously. This change is according to Gilles, ready to be merged.

  • ”Drop the service name from ODU connection name”: this allows limiting the string length of the connection name to something lower than 256 bytes. This change is also ready to be merged.

• Changes in Work In Progress status:

  • ”Add support for 100G OFEC”: Bala still needs to develop the associated functional tests. With this change, the 100G wavelength service can now be created with OFEC and baud rate of 31.6 Gbauds. Xml configuration for honeynode will need to be upgraded to include in the capabilities the possibility to be configured according to that mode.

  • 
    

    Gilles's series associated with Sulfur migration:

    • “Fix list initialization issue in Renderer” is proposed by Gilles to avoid instantiating an ArrayList which kind of anonymous class when the use of a straight forward immutable list is sufficient enough.

    • In “Fix few code issues” : Gilles removed some catching of NPE

    • “Bump upstream dependencies” updates dependencies for migration to Sulfur.

    • “Override asciidoctorj-diagram to 2.2.1” solves a bug in odlparent. This change is provided to handle migration to Sulfur but will not be necessary after odl-parent has been updated to the next minor version.

    • “Adapt transportPCE code to Sulfur” provides some needed code changes to handle the migration to Sulfur (Let's notice that most of them are the replacement of BigDecimal by Decimal64, RPCresultBuilder adaptation, replacement of Lists by Sets to handle yang leaf-lists…)

    • Guillaume proposed also a workaround to temporarily resolve the model compilation issue with the migration to Sulfur through ("Quick and dirty fix to sulfur bug in building”). This change is not intended to be merged.

A.O.B.

• Orange had a meeting with UTD to discuss short term Roadmap of transportPCE, and plans of UTD regarding test automation reusing the CI/CD chain developed in the scope of tpce.

...

• No change was merged this week apart from the changes that have been backported on stable/phosphorus branch.

• No new changes were pushed during this week. Javier discovered making the tests in “Update TAPI connectivity Service on port change” that there was a bug in T-API implementation. The service was not created correctly for service that span across more than 2 ROADMs. This has been fixed in the last Patchset (24) of this change. In ConnectivityUtils a few corrections were also made handling Ids. Comments received so far still need to be taken into acount.

A.O.B.

• An analysis has been initiated to handle OpenConfig models in Honeynode simulator. HoneyComb project has been archived, and the version of yang tools it is based on is now a bit obsolete. It will be very difficult to make it evolve, and an alternative would be to use lighty-netconf-simulator. This is currently investigated. We will probably migrate to lighty for OpenConfig simulators, and when we will be at ease with it, smoothly migrate our OpenROADM simulators to it.

...

• Since the last meeting, 13 changes have been merged:
  • all the relation chain (8 changes) associated with OpenROADM service and network models 10.1.

  • a new relation chain (4 changes) proposed by Guillaume related to minor bug fix/refactor on the previous change related to DowngradeConstraints class (changes 100380, 100381, 100383 and 100416).

  • another new change from Guillaume related to the project building on the gate, to enable the keep-going option in sphinx (change 100430)

  • all changes merged on master up to the Pylint update change have been backported on Phosphorus by Gilles to be part of P-SR3. Among these new merges, we aggree to backport on stable/phosphorus only changes 99379, 99380 and 100430.

• Discussion about other changes under review:

  • Javier rebased changes associated with T-API relation chain. He proposes new additional changes to the relation chain:

    • “Refacto tapi-delete-connectivity-service” which checks the existence of lower order connections before deleting service,

    • for reminder, “Initial tapi notification implementation” allows handling subscription to notifications and “Implementation of T-API notifications rpcs”.

    • He also started working on the associated tests through "T-API notification JUnit test" and "T-API notification functional test". These two new changes are always under development and should be in review very soon.

  •   Gilles proposed a new change “Remove Supported capability conversions from T-API” because he detected some obsolete code in T-API module during his review on Javier's change.

A.O.B.

• Bala made a presentation on “Power settings and sanity checks in OLM” that makes a recap of what they observed during the OFC demo preparation and needs to be corrected.

  • 
    

    Transmit power set on a transponder could be out of the specification range (as an example, higher than maximum value), provided that both the SRG and the transponder supports it (from what is announced in their capabilities).

  • Bala proposed to implement several sanity checks to make sure we set a correct power at the output of transponders.

• 
  

  Christophe proposed an evolution in the way we handle models in TransportPCE (OpenROADM, T-API and may be tomorrow OpenConfig). Right now the models are directly embedded with TransportPCE project and compiled systematically during the project build. It could be interesting to export the compilation of all TransportPCE models outside the project (typically in an ODL sub-project) and use a maven dependency. It should also improve significantly the performances associated with the tests.

...

• Since the last meeting, Guillaume merged is relation chain related to the migration of OLM functional tests towards RFC 8040.

• Discussion about other changes under review:

  • relation chain related to migration of service and network models to 10.1: waiting for migrating to sulfur, Gilles rebased yesterday on current state of master. All changes failed due to an issue associated with a new Pylint version available and used by the gate that detected new issues. Gilles pushed a new change “Fix Pylint issue in pce functional tests” to fix them. Guillaume made some new comments that may need to be addressed.

    • “Refactor style b/c of service models 10.1 updates” => We will need to rediscuss the code style proposal to agree on what shall be done, and what should not be considered. The trailing space issue associated with OpenROADM yang files will be solved in OpenROADM side. Guillaume will raise a ticket to keep trace of it and will propose a new change on TransportPCE to correct them.

    • In “Rewrite the whole downgradeConstraints Test class”, Guillaume also made some comments and made a modification proposal using nested ternary operators. However Gilles feels that it is unreadable , and probably not a so good practice. Majority of opinions raised during the meeting is in favor to not abuse of ternary operator, all the more they are nested.

  • ”Fix the mc-width precision for OLM power value” will need to be abandoned by Bala

• Priority is to finish the service and network model 10.1 and then migrate to Sulfur.

A.O.B.

• Bala will need a time slot of 15' next week to present and discuss a new subject. Indeed, in the OLM there is no sanity checking which sometimes leads to value a bit out of range of the optical specification (based on equipment capabilities)

• Olivier will share inside the TransportPCE team the marketing message for Sulfur. It will be approved next week.

...

• Since the last meeting, 4 changes have been merged. All of them were discussed last week. (Fix power value precision bug, Reintroduce netmod dependency, Fix notification subscription issue, Update karaf cache nc-notifications YANG schema)

• Discussion about other changes under review:

  • 4 changes related to PCE bug: Christophe has split his last big change ”Manages 100GE on XPDR with a list of xponders” into multiple changes as this was handling many things:

    • "Bug correction for the ethernet loop test" => this change is also associated to some improvement reducing the number of loop. OC service was tested several times, but not Ethernet service.
    • "Update Servicehandler checks" => when a service is checked, the leaves of the service create request are checked. Most of these leaves are not mandatory. The checks for non-mandatory leaves have been removed to comply with OR MSA.
    • "Add a list of xponder for XPDR-C1" =>the configuration will be used to check the path computation when there is no transponder list present (Solves an issue raised by Bala during OFC demonstration preparation)
    • "Manage 100GE on XPDR with a list of xponder" => management of the path computation request when there are multiple xponder in a list. One more use case is still not handle : when we don’t have a Xponder list but a port is specified. Then the PCE will select the first available port, which is not tested in the test suite

  • "Refactor PCE networkanalyser PceCAlculation” => Guillaume performed some check factorization. Cherry-picked by Christophe above his changes

  • 7 changes on 10.1 openroadm model migration =>   on network models, and added a new one

    • ”Upgrade openoadm service model to 10.1” => Gilles rebased them

    • ”Upgrade openoadm network model to 10.1” => Gilles rebased also the change from Christophe (rather difficult due to lots of modifications in PCE, GNPy, renderer)

    • ”Refactor SupportedIfCapability usage" => this is a new change proposed by Gilles. The supported interface capability were associated to 3 different name-spaces, and a lot of conversion method were used which was not optimal. During PortMapping, we now apply the latest version of supported interface capability. MappingUtilsImpl gathers all the functions associated to conversions. This allows homogenizing the handling of supported interface capability on the rest of the code.

  • few changes on OLM RFC8040 migration from Guillaume:

    •  "Migrate OLM functional tests to RFC8040 step 2" => always in WIP...

    • ”Migrate OLM functional tests to RFC 8040 step1” => Guillaume solved some issues associated with discrepancies between config and operational data stores. Ready.

    • ”Fix a RFC 8040 test utils method naming” =>just a change in the name of a method.

  • Status on T-API changes : Javier was planning to release some code for T-API connectivity and notification, but will do it next week. He also needs to rebase everything on top of Sulfur.

  • ”Refator style b/c of service model 10.1 update” => several suggestions for code style guidelines were proposed by Guillaume and Gilles. This could be discussed next week, when Bala will be available.

A.O.B.

• Next DDF and ONES events will be collocated in November

...

• Since the last meeting, 9 changes have been merged.

  • “Bump Kafka clien to 3.0 ?.0” and “Fix a bug in a Junit nbiNotifications test” are related to a better version of our kafka-client dependency in nbinotifications module which not provide an incompatible version of Jackson transitive dependency.

  • Also the 2 last tstep of PCE OTN Node refactoring

  • the group of 5 changes pushed by Gilles that are related to the preparation of the Sulfur migration. (“Remove usage of schemaPath from converters”, “Clean dependency declaration in common module”, “Remove usage of deprecated InitMock methods”, “Remove usage of DOMnotification Router. Create method”, “Cleanup Junit test”). They replace object marked as deprecated for removal.

• Discussion about other changes under review:

  • “Adding Kafka messages for OFC22” => change pushed by UTD. This is the code they are using to make the OFC'22 demonstration, as they were missing some notification messages and also some elements related to alarms. Gilles proposed to put this change in progress and private to limit the visibility since device configuration are embedded. As it stands, this change could not be merge.
  • 3 changes related to netmod notifications
    • “Update karaf cache nc-notification Yang schema” was initially inside a change proposed by Shweta a moment ago and reintroduced here by Guillaume.
    • “Fix notification subscription issue” was already discussed.
    • “Reintroduce netmod dependency” is proposed Guillaume to solve some issues introduced by preceding change. Changes are now in the right order, and they can be merged

  • 2 changes related to the power value precision inside OLM module

    • “Fix power value precision bug” is a proposal from Bala. Guillaume splited the change to separate the rounding associated with power value and the one associated with MC width which is now handled in the following change. This change is merged in session.

    • “Fix the mc-precision for OLM Power value”. We should wait before merging this change.

  • 5 changes related to the service models migration to 10.1

    • “Refactor transportpce-routing constraint model” => preliminary step to finally remove the transportpce-routing-constraint that was redundant with the official openroadm model for routing constraint.

    • "Remove transportpce-routing-constraint model" => allows an interesting code dusting, removing now unnecessary classes that was dedicated to convert offical openroadm-routing-constraints to transportpce-routing-constraints.

    • “Upgrade openRoadm service model to 10.1” => has been also rebased.

    • On top of this Guillaume pushed a change “refactor b/c of services models 10.1 update” which focuses on a proposal of a new code style for TransportPCE. Gilles think the principle of having a clear code style inside TransportPCE is a very good thing, but on the other hand, does not totally agree with Guillaume's proposal, especially the fact that systematically put everything on a new line. Gilles suggests every coder could have a look at this code so that they could have an idea of what is suggested by Guillaume, and we can decide later which coding style rules we could agree on and generalize on the project. In the rebase, Gilles modified tow classes (PceTestData and PathComputationServiceImpl) with Gilles's suggestion for the new code style. The advantage of Gilles proposal, is that we save indentation spaces when we have long namespaces, and above all, we can automate much more adjustements directly with eclipse IDE.

    • In ”Rewrite the whole DowngradeConstraints test class”, Gilles also took advantage of the rebase to also appy his code style proposal. Result is esay to see.

  • 1 change related to PCE bug:

    • ”Manage 100GE on XPDR with a list of xponder” has been pushed by Christophe to handle 100GE use case when port or device-name are precised in the service-create request.

  • Always the 4 changes from Nokia on T-API connectivity service and notifications. Gilles proposes that we integrate these T-API changes in the Sulfur distribution.

  • Javier is working on integrating OpenConfig models and translating them to T-API. Honeynode using Generic OpenConfig configurations could be used. Currently, Nokia equipment implement specific Nokia models. To see how the code/node configuration may be adapted without nokia specific models.

A.O.B.

• Gilles would like to discuss about the status change of transportPCE. Currently TransportPCE is a self-managed project. Guillaume, as the TSC chair reported that it could be the right time to move from this mode to an MSI mode (Managed Snapshot Integrated project). Some tasks would be done by other committers of the ODL community (typically, when major API change on core MRI projects), and our release process could be simplified (as being integrated in ODL processes). The drawback for us could be the fact that we would have to follow more stricly the release schedule, especially regarding the code freeze deadline. So this project decision needs to be discussed more deeply during our next meetings before we make the decision. At first sight, that could be applied for Chlorine release train.

...